Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove resources from service #14581

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Remove resources from service #14581

merged 1 commit into from
Apr 3, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Mar 30, 2017

This API enhancement allows for the removal of resources from a service as a follow up to the add resources enhancement.

Remove resources can be done from the collection:

POST /api/services
{
    'action'    => 'remove_resource',
    'resources' => [
          { 'href' => 'api/services/:id','resource' => { 'href' => 'api/vms/:id' },
          { 'href' => 'api/services/:id, 'resource' => { 'href' => 'api/vms/:id'} }
        ]
}

or from the resource:

POST /api/services/:id
{
    'action'   => 'remove_resource',
    'resource' => { 'resource' => {'href' => 'api/vms/:id' }}
}

cc: @mkanoor
@miq-bot add_label enhancement, api
@miq-bot assign @abellotti

@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2017

Checked commit jntullo@3f4a286 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. ⭐

@abellotti
Copy link
Member

Thanks @jntullo for this enhancement, this LGTM!! 😍 will merge when 🍏

@abellotti
Copy link
Member

@jntullo and @mkanoor is this master only or needed in Fine-release ?

@mkanoor
Copy link
Contributor

mkanoor commented Mar 31, 2017

@abellotti @gmcculloug @jntullo
Since we are in alpha can't be add it to the Fine release?

@gmcculloug
Copy link
Member

Checking with @jonnyfiveiq to confirm if we can include in the fine release.

@chriskacerguis
Copy link
Contributor

@gmcculloug SUI does need this for Fine.

@gmcculloug
Copy link
Member

@chriskacerguis Is there a bug, issue or story we can link this to?

@chriskacerguis
Copy link
Contributor

@gmcculloug sure (sorry for not including it). Here's the PT that needs it: https://www.pivotaltracker.com/story/show/142775095

@gmcculloug
Copy link
Member

😕 I am not sure how these two things are related. The pivotal story is for "Retire now" and this PR is for removing resources, like VMs, from a service.

@chriskacerguis
Copy link
Contributor

@gmcculloug the "retire now" is exactly that; we need to remove a resource (such as a VM) from a service.

@abellotti abellotti added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 3, 2017
@abellotti abellotti merged commit 88669e4 into ManageIQ:master Apr 3, 2017
simaishi pushed a commit that referenced this pull request Apr 3, 2017
@abellotti @simaishi
Merge pull request #14581 from jntullo/enhancement/remove_resources
f9a5bb0 
Remove resources from service
(cherry picked from commit 88669e4)
@simaishi
Copy link
Contributor

simaishi commented Apr 3, 2017

Fine backport details:

$ git log -1
commit f9a5bb0f01284d4c8918862e441e8009ae261cda
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Mon Apr 3 15:48:12 2017 -0400

    Merge pull request #14581 from jntullo/enhancement/remove_resources
    
    Remove resources from service
    (cherry picked from commit 88669e4fae2e6f612a4d58983d0aa17e1a0f8c3e)

@jntullo jntullo deleted the enhancement/remove_resources branch April 11, 2017 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@abellotti abellotti

Labels
api enhancement fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jntullo @miq-bot @abellotti @mkanoor @gmcculloug @chriskacerguis @simaishi